From 614c7d98d919769326e8f20b94eeaae8d70368cd Mon Sep 17 00:00:00 2001 From: Dmitriy Smirnov Date: Tue, 2 Jul 2024 14:50:44 +0300 Subject: [PATCH] Fix logic of deleting all port forwarding rules for compute in DecortController.pfw_configure method --- module_utils/decort_utils.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/module_utils/decort_utils.py b/module_utils/decort_utils.py index 29aeb55..b3cd0be 100644 --- a/module_utils/decort_utils.py +++ b/module_utils/decort_utils.py @@ -3142,9 +3142,15 @@ class DecortController(object): if new_rules == None or len(new_rules) == 0: # delete all existing rules for this Compute - api_params = dict(vinsId=vins_facts['id'], - ruleId=-1) - self.decort_api_call(requests.post, "/restmachine/cloudapi/vins/natRuleDel", api_params) + for rule in existing_rules: + self.decort_api_call( + arg_req_function=requests.post, + arg_api_name="/restmachine/cloudapi/vins/natRuleDel", + arg_params={ + 'vinsId': vins_facts['id'], + 'ruleId': rule['id'] + } + ) self.result['changed'] = True return ret_rules